Remove All Hardcoded strings and other warnings #1098
Conversation
|
@Nayan @vorburger @vishwasbabu @siebrand Please review my PR ASAP. |
|
Seems fine to me, you pretty much removed many warnings but why did you changed gradle dependency? |
|
Hello. Thank you for pinging me here. I unfortunately don't have the time
to contribute to this particular sub-project, and therefore regret that I
cannot help review PRs in this repo. Thanks for your understanding!
|
Okay, I will undo the changes in Gradle dependency. |
|
@EGOR-IND @vorburger @Nayan @siebrand Please review my PR again. |
|
@deepak-prajapatii I unfortunately don't have the time to contribute to this particular sub-project, and therefore regret that I cannot help review PRs in this repo. Thanks for your understanding! |
Okay Sir. |
1 similar comment
|
@deepak-prajapatii let me see what you did. |
build.gradle
Outdated
| @@ -8,7 +8,7 @@ buildscript { | |||
| maven { url 'https://maven.google.com' } | |||
| } | |||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:3.6.3' | |||
| classpath 'com.android.tools.build:gradle:4.1.1' | |||
There was a problem hiding this comment.
Yeah everything is fine but why is this here, i mean why you changed gradle
There was a problem hiding this comment.
Okay I undo the changes in few minutes
| @@ -1,7 +1,6 @@ | |||
| #Mon Jan 14 18:31:05 IST 2019 | |||
| #Thu Jan 07 20:26:35 IST 2021 | |||
There was a problem hiding this comment.
And what's the use of this one.
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.4.1-all.zip | ||
|
|
||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip |
There was a problem hiding this comment.
And this one tooo what is this used for, can you explain all these 3 changes that i commented on.
|
@EGOR-IND I will undo the changes as soon as possible. I am a fresher and don't know so much about the Gradle dependencies. |
Did you updated the gradle plugins when you started making changes. |
Yeah, I thought it was a studio update |
|
@EGOR-IND Hey Please check again I have undo the changes. Please if there is something wrong, guide me. |
You should not have done that it creates error, go look at some java file you will find alots of errors there i think you should delete this project and clone it again and then without updating you should start contributing. |
okay |
Issue Fix
Fixes #1090
Description
Removes All hardcoded strings and other warnings in this app.
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.
Fix the warning of showing hardcoded strings and other warnings too.