Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove All Hardcoded strings and other warnings #1098

Closed
wants to merge 5 commits into from
Closed

Remove All Hardcoded strings and other warnings #1098

wants to merge 5 commits into from

Conversation

deepak-prajapatii
Copy link

Issue Fix

Fixes #1090

Description

Removes All hardcoded strings and other warnings in this app.

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

  • Fix the warning of showing hardcoded strings and other warnings too.

@deepak-prajapatii
Copy link
Author

@Nayan @vorburger @vishwasbabu @siebrand Please review my PR ASAP.

@EGOR-IND
Copy link
Contributor

EGOR-IND commented Jan 5, 2021

Seems fine to me, you pretty much removed many warnings but why did you changed gradle dependency?

@vorburger
Copy link
Member

vorburger commented Jan 5, 2021 via email

@deepak-prajapatii
Copy link
Author

Seems fine to me, you pretty much removed many warnings but why did you changed gradle dependency?

Okay, I will undo the changes in Gradle dependency.

@deepak-prajapatii
Copy link
Author

@EGOR-IND @vorburger @Nayan @siebrand Please review my PR again.

@vorburger
Copy link
Member

@deepak-prajapatii I unfortunately don't have the time to contribute to this particular sub-project, and therefore regret that I cannot help review PRs in this repo. Thanks for your understanding!

@deepak-prajapatii
Copy link
Author

@deepak-prajapatii I unfortunately don't have the time to contribute to this particular sub-project, and therefore regret that I cannot help review PRs in this repo. Thanks for your understanding!

Okay Sir.

@deepak-prajapatii
Copy link
Author

@EGOR-IND @Nayan @siebrand Please review my PR again.

@deepak-prajapatii
Copy link
Author

@EGOR-IND @Nayan @siebrand Please review my PR again.

1 similar comment
@deepak-prajapatii
Copy link
Author

@EGOR-IND @Nayan @siebrand Please review my PR again.

@deepak-prajapatii
Copy link
Author

@EGOR-IND @siebrand Please review my PR.

@EGOR-IND
Copy link
Contributor

@deepak-prajapatii let me see what you did.

build.gradle Outdated
@@ -8,7 +8,7 @@ buildscript {
maven { url 'https://maven.google.com' }
}
dependencies {
classpath 'com.android.tools.build:gradle:3.6.3'
classpath 'com.android.tools.build:gradle:4.1.1'
Copy link
Contributor

@EGOR-IND EGOR-IND Jan 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah everything is fine but why is this here, i mean why you changed gradle

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I undo the changes in few minutes

@@ -1,7 +1,6 @@
#Mon Jan 14 18:31:05 IST 2019
#Thu Jan 07 20:26:35 IST 2021
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what's the use of this one.

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.4.1-all.zip

distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one tooo what is this used for, can you explain all these 3 changes that i commented on.

Copy link
Contributor

@EGOR-IND EGOR-IND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash all your commits in one commit

@deepak-prajapatii
Copy link
Author

@EGOR-IND I will undo the changes as soon as possible. I am a fresher and don't know so much about the Gradle dependencies.

@EGOR-IND
Copy link
Contributor

@EGOR-IND I will undo the changes as soon as possible. I am a fresher and don't know so much about the Gradle dependencies.

Did you updated the gradle plugins when you started making changes.

@deepak-prajapatii
Copy link
Author

@EGOR-IND I will undo the changes as soon as possible. I am a fresher and don't know so much about the Gradle dependencies.

Did you updated the gradle plugins when you started making changes.

Yeah, I thought it was a studio update

@deepak-prajapatii
Copy link
Author

@EGOR-IND Hey Please check again I have undo the changes. Please if there is something wrong, guide me.

@EGOR-IND
Copy link
Contributor

@EGOR-IND I will undo the changes as soon as possible. I am a fresher and don't know so much about the Gradle dependencies.

Did you updated the gradle plugins when you started making changes.

Yeah, I thought it was a studio update

You should not have done that it creates error, go look at some java file you will find alots of errors there i think you should delete this project and clone it again and then without updating you should start contributing.

@deepak-prajapatii
Copy link
Author

@EGOR-IND I will undo the changes as soon as possible. I am a fresher and don't know so much about the Gradle dependencies.

Did you updated the gradle plugins when you started making changes.

Yeah, I thought it was a studio update

You should not have done that it creates error, go look at some java file you will find alots of errors there i think you should delete this project and clone it again and then without updating you should start contributing.

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all "Hardcoded Strings" in all XML file of this app.
4 participants