Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Cleanup - Refactor Deprecated Libraries & Apply Custom Lint #1752

Merged
merged 8 commits into from
Aug 25, 2024

Conversation

niyajali
Copy link
Collaborator

@niyajali niyajali commented Aug 25, 2024

Issue Fix

Fixes #{Issue Number}
Jira Task: MW-138

Screenshots

Description

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Updated the splash screen icon to use the correct drawable and adjusted the size of the icon in the drawable
.
Also, disabled the `ResourceName` lint rule until the libraries are shipped to Maven.
Finally, updated the CI workflow to include the dependency guard job in the build job's needs.
@therajanmaurya therajanmaurya merged commit dc95c55 into openMF:dev Aug 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants