Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-Env-TC] Fix Env TC #448

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

[fix-Env-TC] Fix Env TC #448

wants to merge 86 commits into from

Conversation

shkr7
Copy link
Contributor

@shkr7 shkr7 commented Jun 3, 2024

Description

  • PR title should have jira ticket enclosed in [].

    Format: [jira_ticket] description

    ex: [phee-123] PR title.
  • Add a link to the Jira ticket.
  • Describe the changes made and why they were made.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Followed the PR title naming convention mentioned above.

  • Design related bullet points or design document link related to this PR added in the description above.

  • Updated corresponding Postman Collection or Api documentation for the changes in this PR.

  • Created/updated unit or integration tests for verifying the changes made.

  • Added required Swagger annotation and update API documentation with details of any API changes if applicable

  • Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed below as a comment.
It’s highly recommended that you fix this security issue before merge.

@@ -329,6 +346,11 @@ operationsmysql:
username: "mifos"
password: "password"
rootPassword: "4ET6ywqlGt"
primary:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Secret Detection

Type: Hashicorp-Tf-Password

Description: Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.

Severity: HIGH



Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_undo_ignore Undo ignore command

@shkr7 shkr7 changed the title [fixEnvTC] Fix Env TC [fix-Env-TC] Fix Env TC Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants