Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHEE-296A] Test #455

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[PHEE-296A] Test #455

wants to merge 3 commits into from

Conversation

ankita10r
Copy link
Contributor

Description

  • PR title should have jira ticket enclosed in [].

    Format: [jira_ticket] description

    ex: [phee-123] PR title.
  • Add a link to the Jira ticket.
  • Describe the changes made and why they were made.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Followed the PR title naming convention mentioned above.

  • Design related bullet points or design document link related to this PR added in the description above.

  • Updated corresponding Postman Collection or Api documentation for the changes in this PR.

  • Created/updated unit or integration tests for verifying the changes made.

  • Added required Swagger annotation and update API documentation with details of any API changes if applicable

  • Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing

# echo "create nginx conf"
# sudo chmod 777 -R /etc/nginx/conf.d/
# echo "changed access"
sudo apt install nginx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep these lines commented

@@ -45,6 +45,8 @@ It directly provides values.
fieldPath: status.podIP
- name: "CALLBACK_URL"
value: "http://$(MY_POD_IP):53013"
- name: "EMAIL_URL"
value: "http://$(MY_POD_IP):3025"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think message gateway is not currently part of ephemeral, please check that once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants