Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for ADIOS2 Git sample #1019

Merged
merged 6 commits into from
Jul 2, 2021
Merged

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Jun 24, 2021

Add testing for the ADIOS2 example data files: openPMD/openPMD-example-datasets#14

  • Test attributes
  • Test content

This does not test attributes as extensively as in the HDF5 sample, since we don't need to test the entire openPMD hierarchy a second time. Hence, some but not all meshes and particles are tested.

Also, I noticed that our HDF5 sample has some wrong unitDimensions.

Otherwise any other errors when opening the file might be swallowed too
@ax3l ax3l self-assigned this Jul 2, 2021
@ax3l ax3l self-requested a review July 2, 2021 01:05
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I added windows support and some cleanups :)

@ax3l ax3l enabled auto-merge (squash) July 2, 2021 01:29
@ax3l ax3l merged commit cb16e38 into openPMD:dev Jul 2, 2021
@ax3l
Copy link
Member

ax3l commented Jul 3, 2021

Dang, I just found a bug in that data set: openPMD/openPMD-example-datasets#14 (comment)

Try to:

  • determine the extend of a constant record component (particle mass/charge), it should be the same size as the non-constant records
  • try to read the constant record component (mass or charge) like a non-constant one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants