Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush target newstep #1632

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Flush target newstep #1632

merged 6 commits into from
Jul 16, 2024

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Jun 11, 2024

Introduces a new flush target "new_step" used for creating readable output in file-based iteration encoding while the Iteration is not yet fully defined yet.

Close #1629

@franzpoeschel franzpoeschel added this to the 0.17.0 milestone Jun 11, 2024
@ax3l ax3l modified the milestones: 0.17.0, 0.16.0 Jun 11, 2024
@ax3l ax3l self-requested a review June 11, 2024 17:24
@franzpoeschel franzpoeschel force-pushed the flush_target_newstep branch from c08d260 to 11279f6 Compare June 12, 2024 11:13
test/SerialIOTest.cpp Outdated Show resolved Hide resolved
@franzpoeschel franzpoeschel mentioned this pull request Jun 21, 2024
2 tasks
@franzpoeschel franzpoeschel force-pushed the flush_target_newstep branch from f099a4e to 2feae75 Compare June 25, 2024 12:05
@franzpoeschel franzpoeschel mentioned this pull request Jul 11, 2024
3 tasks
@franzpoeschel franzpoeschel force-pushed the flush_target_newstep branch from 2feae75 to 247b01e Compare July 16, 2024 09:32
@ax3l ax3l requested a review from guj July 16, 2024 17:11
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome.

Let us also add a parallel test to cover serial and parallel I/O.

@ax3l ax3l merged commit 5a24100 into openPMD:dev Jul 16, 2024
30 of 31 checks passed
@franzpoeschel
Copy link
Contributor Author

This is awesome.

Let us also add a parallel test to cover serial and parallel I/O.

Done as part of follow-up #1638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flush_target that ends/starts step
2 participants