Compatibility with toml11 4.0 #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
added
third party
franzpoeschel
force-pushed
the
toml11-4.0
branch
2 times, most recently
from
8c5cd8d to
6d628ef
Compare
franzpoeschel
force-pushed
the
toml11-4.0
branch
from
488d265 to
d2cb0ba
Compare
ax3l
reviewed
Jul 16, 2024
franzpoeschel
commented
Jul 16, 2024
ax3l
reviewed
Jul 16, 2024
franzpoeschel
force-pushed
the
toml11-4.0
branch
from
3257b5c to
6f9159b
Compare
Still missing: proper setting for precision, backwards compatibility with toml11 3.0. Ideally, move toml::format to an internal helper that takes care of all of this.
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
franzpoeschel
force-pushed
the
toml11-4.0
branch
from
df0340c to
51198b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toml11 4.0+ seems to be a breaking change. Especially, output formatting now works differently.