Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CMake Internal Control #1678

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix: CMake Internal Control #1678

merged 1 commit into from
Oct 8, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Oct 8, 2024

The openPMD_USE_INTERNAL_* options are for general internal/external control. They were accidentally overwritten by new tar flags and sometimes incomplete.

Follow-up to #1668

@ax3l ax3l added this to the 0.16.1 milestone Oct 8, 2024
@ax3l ax3l force-pushed the fix-cmake-internal branch from ccf3054 to b41d157 Compare October 8, 2024 17:46
@ax3l ax3l mentioned this pull request Oct 8, 2024
2 tasks
@ax3l ax3l force-pushed the fix-cmake-internal branch from b41d157 to 5e85670 Compare October 8, 2024 17:51
@ax3l ax3l requested a review from franzpoeschel October 8, 2024 17:52
@ax3l ax3l force-pushed the fix-cmake-internal branch from 5e85670 to 47bcafb Compare October 8, 2024 17:53
ax3l added a commit to regro-cf-autotick-bot/openpmd-api-feedstock that referenced this pull request Oct 8, 2024
ax3l added a commit to ax3l/spack that referenced this pull request Oct 8, 2024
openPMD/openPMD-api#1678

Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>
ax3l added a commit to openPMD/homebrew-openPMD that referenced this pull request Oct 8, 2024
The `openPMD_USE_INTERNAL_*` options are for general internal/external
control. They were accidentally overwritten by new tar flags
and sometimes incomplete.

Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>
@ax3l ax3l force-pushed the fix-cmake-internal branch from 47bcafb to bcb1e17 Compare October 8, 2024 18:19
ax3l added a commit to ax3l/spack that referenced this pull request Oct 8, 2024
openPMD/openPMD-api#1678

Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>
ax3l added a commit to openPMD/homebrew-openPMD that referenced this pull request Oct 8, 2024
@ax3l ax3l enabled auto-merge (squash) October 8, 2024 19:15
@ax3l ax3l merged commit 3dc3a46 into openPMD:dev Oct 8, 2024
31 checks passed
@ax3l ax3l deleted the fix-cmake-internal branch October 8, 2024 19:18
ax3l added a commit to ax3l/spack that referenced this pull request Oct 8, 2024
openPMD/openPMD-api#1678

Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>
Copy link
Contributor

@franzpoeschel franzpoeschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you!

franzpoeschel added a commit to ax3l/openPMD-api that referenced this pull request Oct 10, 2024
ax3l added a commit to spack/spack that referenced this pull request Oct 10, 2024
* openPMD-api: 0.16.0

Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>

* [Patch] Fix: CMake Internal Control

openPMD/openPMD-api#1678

Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>
arezaii pushed a commit to arezaii/spack that referenced this pull request Oct 22, 2024
* openPMD-api: 0.16.0

Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>

* [Patch] Fix: CMake Internal Control

openPMD/openPMD-api#1678

Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>
franzpoeschel pushed a commit to ax3l/openPMD-api that referenced this pull request Dec 20, 2024
The `openPMD_USE_INTERNAL_*` options are for general internal/external
control. They were accidentally overwritten by new tar flags
and sometimes incomplete.

Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants