CMake: Optional ADIOS1 Wrapper Libs #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
changed the title
ax3l
force-pushed
the
topic-optADIOS1capsuleLib
branch
2 times, most recently
from
0f4a249 to
d9c0525
Compare
We need to build and install the optional libs to wrap ADIOS1 (hide doubly defined MPI mock symbols in serial lib) only if we actually enable ADIOS1 support. Otherwise, we can also throw the missing support warning early on, without the need for implementation files and auxiliary libraries that wrap a dummy ADIOS1.
ax3l
force-pushed
the
topic-optADIOS1capsuleLib
branch
from
d9c0525 to
90a4a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to build and install the optional libs to wrap ADIOS1 (hide doubly defined MPI mock symbols in serial lib, see #254) only if we actually enable ADIOS1 support.
Otherwise, we can also throw the missing support warning early on, without the need for implementation files and auxiliary libraries that wrap a dummy ADIOS1 IO backend.