Fix bug in ADIOS2 dataset, add two filebased iterations #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shapes of constant records components now correct: uint64_t /data/550/particles/e/charge/shape attr = 96781 uint64_t /data/550/particles/e/mass/shape attr = 96781 uint64_t /data/550/particles/i/charge/shape attr = 19838 uint64_t /data/550/particles/i/mass/shape attr = 19838
|
Note: Due to ComputationalRadiationPhysics/picongpu#3672, the resulting datasets are likely not identical any more, meaning that tests need to be rewritten. |
This was referenced Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for the dataset added with #14
Shapes of constant records components now correct:
Also, adds two iterations in a file-based iteration encoding for advanced testing.
Related: Bug fixed in PIConGPU ComputationalRadiationPhysics/picongpu#3678