Make multiplying with unit_SI optional #309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSinn
changed the title
ax3l
reviewed
Mar 4, 2021
openpmd_viewer/openpmd_timeseries/data_reader/h5py_reader/particle_reader.py
Outdated
Show resolved
Hide resolved
ax3l
reviewed
Apr 7, 2021
| data += offset | ||
| # - Return momentum in normalized units | ||
| elif component_name in ['ux', 'uy', 'uz' ]: | ||
| elif component_name in ['ux', 'uy', 'uz' ] and units == 'SI_u': |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to change the unit conversion when reading in data.
By specifying
units='SI'inOpenPMDTimeSeries(), the functionsget_particle()andget_field()will output pure SI data.'SI_u'(default) will give SI data but with normalized particle momentum, like how it is currently.'raw'will ignore all unit_SI attributes. (but will still multiply the particle data with weighting if appropriate)With this approach more unit systems can be added to
read_species_data()in the future.Related to #209