catatoinit: rewrite LISTEN_PID to the child process #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't test it, but lgtm |
cyphar
requested changes
Sep 15, 2021
In order to get systemd fd passing let's rewrite the LISTEN_PID environment variable if it is pointing to catatonit init process. Closes: openSUSE#13 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
rewrite-LISTEN_PID
branch
from
75b9133 to
0de094f
Compare
|
thanks for the review. I've addressed your comments in the last commit |
|
I'll do a new release once #14 is merged. |
alexlarsson
added a commit
to alexlarsson/podman
that referenced
this pull request
Oct 25, 2022
This was added in the old quadlet to work around issues with podman not passing on notify fds and pids. However, these are now fixed with: containers#11316 openSUSE/catatonit#15 So, remove this key (which was never in a podman release anyway) Signed-off-by: Alexander Larsson <alexl@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get systemd fd passing let's rewrite the LISTEN_PID
environment variable if it is pointing to catatonit init process.
Closes: #13
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com