-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KIWI: Allow to extend cointainer name with profile #763
Conversation
This should be default, but changing the default would break existing aggregates. This has also a limitation that it only works properly when build just one profile per build atm.
Wouldn't it be possible to solve the original issue in a less ugly way instead? Then something like this wouldn't be necessary. See openSUSE/open-build-service#11032 for my suggested approach. |
No, that's not possible. |
Let me explain: of course it's possible to use the repository of the first tag if the tag-to-add starts with ':'. But you still want a different container name, so that both the containers are visible in the :full tree. |
(The tags are like rpm provides.) |
As only aggregates are affected, can we have this as prjconf flag instead? That way we don't have to uglify kiwi descriptions until the end of time. |
I wrote the script that checked all of the existing aggregates, and the only affected packages are: IBShome:favogt:containers-sle15/15.0 OBShome:favogt:releasetest:Leap/15.0 (The OBS scan is still in progress...) Almost all of the above do not use any profile, so they are safe as well. Thus, I changed my mind and now consider it a severe bug that the profile is not in the container name. I.e. we should change the code to always add it if a profile is used. |
Yay! On IBS, I'm not aware of any container built with kiwi profiles + multibuild. On OBS, Leap and Tumbleweed containers use them, but only Leap passes through Only slightly tricky part is the transition time. The
|
I adjusted |
This should be default, but changing the default would break existing
aggregates.
This has also a limitation that it only works properly when build just
one profile per build atm.