Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIWI: Allow to extend cointainer name with profile #763

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

adrianschroeter
Copy link
Member

This should be default, but changing the default would break existing
aggregates.

This has also a limitation that it only works properly when build just
one profile per build atm.

This should be default, but changing the default would break existing
aggregates.

This has also a limitation that it only works properly when build just
one profile per build atm.
@Vogtinator
Copy link
Member

Wouldn't it be possible to solve the original issue in a less ugly way instead? Then something like this wouldn't be necessary. See openSUSE/open-build-service#11032 for my suggested approach.

@mlschroe
Copy link
Member

No, that's not possible.

@mlschroe
Copy link
Member

Let me explain: of course it's possible to use the repository of the first tag if the tag-to-add starts with ':'. But you still want a different container name, so that both the containers are visible in the :full tree.

@mlschroe
Copy link
Member

(The tags are like rpm provides.)

@mlschroe mlschroe merged commit 1f7008c into openSUSE:master Jan 19, 2022
@Vogtinator
Copy link
Member

As only aggregates are affected, can we have this as prjconf flag instead? That way we don't have to uglify kiwi descriptions until the end of time.

@mlschroe
Copy link
Member

I wrote the script that checked all of the existing aggregates, and the only affected packages are:

IBS

home:favogt:containers-sle15/15.0
home:favogt:containers-sle15/15.1
home:favogt:releasetest:Containers:PrjS/15.0
home:favogt:releasetest:Containers:PrjS/15.1
home:msmeissn/containers
SUSE:Containers:SLE-SERVER:15/15_0
SUSE:Containers:SLE-SERVER:15/15_1
SUSE:Containers:SLE-SERVER:15/15_2
SUSE:Containers:SLE-SERVER:15/15_3
SUSE:Containers:SLE-SERVER:15/15_4
SUSE:Containers:SLE-SERVER:15/kubevirt_15_2
SUSE:Containers:SLE-SERVER:15/kubevirt_15_3
SUSE:Containers:SLE-SERVER:15/kubevirt_15_4
SUSE:Containers:SLE-SERVER:15/others

OBS

home:favogt:releasetest:Leap/15.0
home:favogt:releasetest:Leap/15.0-ports
home:favogt:releasetest:Leap/15.3-dnf
home:favogt:releasetest:Leap/42.3
openSUSE:Containers:Leap/15.0
openSUSE:Containers:Leap/15.0-ports
openSUSE:Containers:Leap/15.1
openSUSE:Containers:Leap/15.1-ppc64le
openSUSE:Containers:Leap/15.2
openSUSE:Containers:Leap/15.2.1
openSUSE:Containers:Leap/15.2-ppc64le
openSUSE:Containers:Leap/15.3
openSUSE:Containers:Leap/15.3-armv7l
openSUSE:Containers:Leap/15.3-dnf
openSUSE:Containers:Leap/15.4
openSUSE:Containers:Leap/15.4-armv7l
openSUSE:Containers:Leap/15.4-dnf
openSUSE:Containers:Leap/42.3

(The OBS scan is still in progress...)

Almost all of the above do not use any profile, so they are safe as well.

Thus, I changed my mind and now consider it a severe bug that the profile is not in the container name. I.e. we should change the code to always add it if a profile is used.

@Vogtinator
Copy link
Member

Yay!

On IBS, I'm not aware of any container built with kiwi profiles + multibuild.

On OBS, Leap and Tumbleweed containers use them, but only Leap passes through _aggregates. It'll only affect 15.3 and 15.4 though, the others aren't built anymore and will keep working.

Only slightly tricky part is the transition time. The _aggregates need to work with both current and new OBS behaviour until the change is completed. For 15.3, there will be images with the old name staying around, so those have to be compatible anyway. That should be easy to implement by just aggregating the old and new names:

<aggregatelist>
  <aggregate project="openSUSE:Containers:Leap:15.3">
    <binary>container:opensuse-leap-image</binary>
    <binary>container:opensuse-leap-image-docker</binary>
  </aggregate>
</aggregatelist>

@Vogtinator
Copy link
Member

Vogtinator commented Jan 20, 2022

I adjusted openSUSE:Containers:Leap/15.3{,-dnf,-armv7l} and openSUSE:Containers:Leap/15.4{,-dnf,-armv7l} to list both names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants