-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mkosi: implement obsbinlnk #872
base: master
Are you sure you want to change the base?
Conversation
@mlschroe @adrianschroeter need some help as this is not yet working, and I can't figure out what the problem is - I followed the same pattern as 50b1a58 but still I can't get an .obsbinlnk file. I also tried to implement query() but that also doesn't help. What am I missing? |
Can you give us a setup (either via git or somewhere in build.o.o) where we could have a look? basically a two mkosi image build setup. |
Allow to build mkosi images using other mkosi images (systemd-sysext)
@adrianschroeter sure, this is the base: https://build.opensuse.org/package/show/home:bluca:mkosi/suse-image and this is the extension that should pull the base in ( https://build.opensuse.org/package/show/home:bluca:mkosi/suse-sysext With the patches from this PR applied, the build stays unresolvable in my local VM. I've also pushed a patch to add Thank you! |
@adrianschroeter did you have a chance to have a look at this? |
@adrianschroeter @mlschroe gentle ping on this issue |
looks like this is almost working in pbuild. The code produces a .obsbinlnk file with content like this:
I think the name needs to be prefixed with something like |
@@ -67,11 +67,75 @@ sub parse { | |||
if (length $cfg->val('Content', 'BuildPackages')) { | |||
push(@packages, split /\s+/, $cfg->val('Content', 'BuildPackages')); | |||
} | |||
if (length $cfg->val('Partitions', 'BaseImage')) { | |||
push(@packages, $cfg->val('Partitions', 'BaseImage')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here it should add the prefix mkosi:
I think
I've added that - do you know where the side that consumes it lives, to make it parse that? |
Got it working with something that looks like this:
Consumer would be |
Allow to build mkosi images using other mkosi images (systemd-sysext)