Only allow a --filename that resolves to file in pwd #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmueller
reviewed
Aug 29, 2018
git_tarballs
Outdated
| basename = os.path.basename(filename) | ||
| if os.path.abspath(filename) != os.path.abspath(basename): | ||
| # no arbitrary filename, please | ||
| sys.exit("%s: illegal filename" % filename) |
There was a problem hiding this comment.
can you make that a little bit more explicit ? "illegal filename" is not very helpful if thrown. maybe say something like "--filename needs to be pointing to a file in the current directory" ?
marcus-h
force-pushed
the
check_filenames
branch
from
ee5b9df to
4f80307
Compare
An arbitrary filename can be a "security" issue. Also, check the --package parameter, because otherwise we could "modify" an arbitrary *.changes file (less critical, though).
marcus-h
force-pushed
the
check_filenames
branch
from
4f80307 to
1168e7b
Compare
|
On 2018-08-29 02:37:56 -0700, Dirk Mueller wrote:
dirkmueller commented on this pull request.
can you make that a little bit more explicit ? "illegal filename" is not very helpful if thrown. maybe say something like "--filename needs to be pointing to a file in the current directory" ?
Yep, I just did a forced push.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An arbitrary filename can be a "security" issue. Also, check the
--package parameter, because otherwise we could "modify" an arbitrary
*.changes file (less critical, though).