Incorrect appdata icons archive being generated by the publisher

[doccaz]

OBS is generating the icons archive for appdata in the repodata directory with the name "app-icons.tar.gz" (more specifically, bs_publisher does that).

The expected behavior is that the bs_publisher component should deal with each case accordingly, e.g. generate app-icons.tar.gz for SLE12 and lower, and appdata-icons.tar.gz for SLE15 and newer. This is necessary because since SLE15/Leap 15, the libzypp appdata plugin checks for "appdata-icons.tar.gz":
https://github.com/DimStar77/openSUSE-appstream/blob/master/AsHelper.py

If it cannot find the proper icons archive, ALL appdata for that repository is ignored, and thus GNOME Software won't show the packages as available.

I currently have a customer that is using a private OBS instance (version 2.9.5-51.4) to generate packages automatically for GNOME Software (with a few thousand clients running on SLED 12 SP4). They cannot migrate these to SLE 15 due to this problem.

The package brp-extract-appdata was broken for SLE15+ as well, I proposed a patch already: openSUSE/brp-extract-appdata#2

[doccaz]

PR closed, thanks!