Change events payload column size from TEXT to MEDIUMTEXT #15649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically this solves the openSUSE#15104 and may others issues related to notify system. When a description hit the char limit (65535 ~ 64kb), the event payload that has the same limit, add more info over the description, like author and so on making the after_create notify crash due to oversized payload (> 65535 chars)
danidoni
approved these changes
Feb 15, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this solves the #15104 and may others issues related to notify system. When a description hit the char limit (65535 ~ 64kb), the event payload that has the same limit, add more info over the description, like author and so on making the after_create notify crash due to oversized payload (> 65535 chars)
Replacing #15513 because there are some conflicts and we need to deploy it in maintenance window