Deprecate action details #15794
Merged
Deprecate action details #15794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncounter
force-pushed
the
deprecate-action-details
branch
9 times, most recently
from
830b46a to
9113b59
Compare
danidoni
reviewed
Mar 15, 2024
danidoni
reviewed
Mar 15, 2024
src/api/app/components/bs_request_action_description_component.rb
Outdated
Show resolved
Hide resolved
danidoni
reviewed
Mar 15, 2024
ncounter
force-pushed
the
deprecate-action-details
branch
3 times, most recently
from
f2f5bf5 to
6c4ed21
Compare
ncounter
force-pushed
the
deprecate-action-details
branch
6 times, most recently
from
a1a3486 to
5bcec07
Compare
hellcp-work
reviewed
Mar 15, 2024
src/api/app/components/bs_request_activity_timeline_component.rb
Outdated
Show resolved
Hide resolved
ncounter
force-pushed
the
deprecate-action-details
branch
2 times, most recently
from
6926e41 to
1694a06
Compare
This was referenced Mar 15, 2024
ncounter
force-pushed
the
deprecate-action-details
branch
10 times, most recently
from
2920bb8 to
5bec028
Compare
danidoni
force-pushed
the
deprecate-action-details
branch
from
ca17536 to
d45f961
Compare
ncounter
force-pushed
the
deprecate-action-details
branch
2 times, most recently
from
a4770f4 to
dd5f1f1
Compare
DEPRECATING webui_action and action_details: For request_workflow_redesign beta feature stop using hash, use the BsRequestAction object instead: it implements all the methods to return the requested information. This is not aiming to touch the non-beta codepath, after the rollout those methods will be dropped instead.
ncounter
force-pushed
the
deprecate-action-details
branch
2 times, most recently
from
7073716 to
224146a
Compare
danidoni
reviewed
Mar 22, 2024
src/api/app/components/bs_request_activity_timeline_component.rb
Outdated
Show resolved
Hide resolved
ncounter
force-pushed
the
deprecate-action-details
branch
from
224146a to
60cb334
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15794 +/- ##
==========================================
- Coverage 86.09% 85.98% -0.11%
==========================================
Files 794 794
Lines 26032 26078 +46
==========================================
+ Hits 22411 22424 +13
- Misses 3621 3654 +33 |
danidoni
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
Missing methods implementations #15827webui_actionsandaction_detailsare old fashioned functions they returnHash {}objectsThe object is a core typified one of the app, which is a
BsRequestAction.This PR forks the code-path differenciating the Beta version from the old one where the first one benefits of the
BsRequestActionobject with all its methods to retrieve all the properties at the time of the need, the former one still uses the old fashioned functions instead.For now the old stack is just deprecated by a comment. Once Beta version will be rolled out, those deprecated functions can be dropped.
Review:
Commit-by-commit is suggested