Change label_template's color field to string #16634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellcp-work
approved these changes
Aug 5, 2024
danidoni
force-pushed
the
change-label-templates-color-field-to-string
branch
from
ecffb83 to
7d73256
Compare
Rails form field helpers for color expect a string so it's easier if we just use a string field instead of a numeric one
danidoni
force-pushed
the
change-label-templates-color-field-to-string
branch
from
7d73256 to
4d351d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails form field helpers for color expect a string so it's easier if we just use a string field instead of a numeric one.
The field change locks the table during the migration, but as no one is using this table on our reference server it's safe to deploy this whenever we see fit.