Handle project sources in a consistent fashion #16928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2024
|
we still need deleted=0 and we can not break compability. deleted=1 also still needs to work, but it is not the documented and recommended option. deleted is just a boolean by existens. |
This way `?deleted=0` and `?` behaves consistently, and only `?deleted=1` activates the behaviour for deleted projects Fixes openSUSE#9715
There was a consistency gap between sources coming from local projects and sources coming from remote projects. Multibuild flavors were only shown for remote projects. Now the multibuild flavors are shown in both cases. Fixes openSUSE#16911
danidoni
force-pushed
the
handle-project-sources-in-a-consistent-fashion
branch
from
48cfd32 to
b1bb5f2
Compare
danidoni
force-pushed
the
handle-project-sources-in-a-consistent-fashion
branch
from
041eefe to
853471a
Compare
|
Closing in favor of #16955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a consistency gap between sources coming from local projects and sources coming from remote projects. Multibuild flavors were only shown for remote projects. Now the multibuild flavors are shown in both cases.
deleted=0 will no longer be valid, only deleted=1 will trigger the desired behaviour.
Fixes #9715
Fixes #16911