Update nokogiri #3910
Merged
Update nokogiri #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a security issue with libxml2 which is used by nokogiri. (CVE-2017-0663).
eduardoj
requested changes
Sep 27, 2017
src/api/test/unit/schema_test.rb
Outdated
| @@ -19,7 +19,6 @@ class SchemaTest < ActiveSupport::TestCase | |||
| if io | |||
| testresult = io.read | |||
| io.close | |||
| # rubocop:disable Style/NumericPredicate | |||
| assert $? == 0, "#{testfile} does not validate against #{f} -> #{testresult}" | |||
| # rubocop:enable Style/NumericPredicate | |||
| end | |||
There was a problem hiding this comment.
This rubocop:enable line can also be deleted.
There was a problem hiding this comment.
this was automatically corrected by rubocop, but yes 👍
There was a problem hiding this comment.
I sent an issue to Rubocop regarding this 😉
DavidKang
suggested changes
Sep 27, 2017
|
Apart from my comment, LGTM |
We need to set the Ruby target version in Rubocop to 2.4 due to a bug in the parser that makes our test suite fail. Changing the Ruby version introduced new offenses that had been automatically added to the todo file. After that, a `Lint/UnneededDisable` offense appeared, due to having added that file to the todo file. It was automatically corrected.
|
@eduardoj @DavidKang please re-review it! |
DavidKang
approved these changes
Sep 27, 2017
eduardoj
approved these changes
Sep 27, 2017
bgeuken
approved these changes
Sep 27, 2017
|
note that there is no security problem fixed by this as our nokogiri gem does not bundle libxml but uses the system's libxml and the fix for that cve is out since july |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a security issue with libxml2 which is used by nokogiri. (CVE-2017-0663).
Supersedes #3902 In this Pr the Rubocop fix is added.