[frontend] Change events.payload to mediumtext #4320
Conversation
We need to make this column bigger as `comment.body` is `text` as well and it many cases it is too big that we get the following error: _Mysql2::Error: Data too long for column 'event_payload'_
|
I dont think we should be increasing the size of comments.body, instead i think we should enforce a limit. mediumtext allows up to 16million characters, for reference the bible is ~3.5 million characters, why does anybody need to write a comment that long? Henne mentioned that the opensuse:factory team use the comments to save data somehow (I'm still unclear of the details) but to me this seems like a misuse of our system so I dont think we should be accommodating for something like that. IMO it would be better would be to ask them what it is they need and then build a feature for them properly so we dont run into problems like this. |
|
@hennevogel would it be possible to decrease the comments size then or build this in another way? |
Codecov Report
@@ Coverage Diff @@
## master #4320 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 350 350
Lines 18654 18654
=======================================
Hits 16430 16430
Misses 2224 2224
|
|
Hey! @Ana06 @evanrolfe, this is not needed! You already agreed in the other PR about not changing the events table to a bigger field or am I wrong?. BTW I'm fixing this already, is the card that talks about to have just one encoder for JSON payloads... please, close this PR. |
mdeniz
added
DO NOT MERGE ⚠️
|
Ok, closing it as we talked in person, thanks @Ana06 |
We need to make this column bigger as
comment.bodyistextas well and it many cases it is too big that we get the following error:Mysql2::Error: Data too long for column 'event_payload'
Fixes #4319