Support a local build of a local multibuild package #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows, for instance, for building a local multibuild package. Fixes: openSUSE/osc#376 ("osc build -M something does not work with --alternative-project")
We simply strip the multibuild suffix (aka flavor) from the package name and check if the result equals "_repository" (note that the backend's flavor stripping code and Package.striping_multibuild_suffix [sic!] are a bit "inconsistent" (but it should not cause any trouble)).
Codecov Report
@@ Coverage Diff @@
## master #4461 +/- ##
==========================================
- Coverage 88.43% 88.41% -0.03%
==========================================
Files 352 352
Lines 18694 18694
==========================================
- Hits 16532 16528 -4
- Misses 2162 2166 +4
|
hennevogel
approved these changes
Feb 8, 2018
hennevogel
added
Bug
Frontend
This was referenced Feb 12, 2018
|
@mlschroe Could you take a look at the backend part? |
|
@openSUSE/open-build-service hey backend peepz, are you going to look at this some time? 1.5 months old by now... |
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support a local build of a local multibuild package (untested).
Fixes: openSUSE/osc#376 ("osc build -M something
does not work with --alternative-project")