Introduces client side javascript error tracking #8196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hennevogel
force-pushed
the
feature/catch-javascript-errors
branch
from
8b6dd3d to
962d4ae
Compare
danidoni
approved these changes
Aug 29, 2019
hennevogel
added
the
DO NOT MERGE ⚠️
|
there is debug code... 🙈🙉🙊 |
hennevogel
force-pushed
the
feature/catch-javascript-errors
branch
from
962d4ae to
d8ec633
Compare
hennevogel
removed
the
DO NOT MERGE ⚠️
As a developer you might be interested in exceptions that occur in the javascript that is running in the users browser. Separate this with another errbit configuration key because this is getting exposed publicly.
hennevogel
force-pushed
the
feature/catch-javascript-errors
branch
from
d8ec633 to
ba660a5
Compare
danidoni
requested changes
Aug 29, 2019
dmarcoux
reviewed
Aug 29, 2019
| var promise = airbrake.notify(error); | ||
| promise.then(function(notice) { | ||
| if (notice.id) { | ||
| // console.log('Notified errbit. Notice:', notice.id); |
There was a problem hiding this comment.
I believe we should remove those console.log calls if they are commented.
danidoni
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer you might be interested in exceptions that occur in the
javascript that is running in the users browser. Separate this with another
errbit configuration key because this is getting exposed publicly.