Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] fix editing of issue tracker entries #8346

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

adrianschroeter
Copy link
Member

@adrianschroeter adrianschroeter commented Sep 13, 2019

eg. via

# osc api -e /issue_trackers/$tracker
we need to backport in case 2.10 is also affected.

Also all other places in test suite where "put ...., params: $body_data"
is used needs to be checked if we broke the api there as well.
needs to become raw_put again...

@hennevogel
Copy link
Member

Maybe you can explain what the problem actually is that you are fixing?

@adrianschroeter
Copy link
Member Author

that it isn't working basically and all changes get ignored when use as described in the api. Just run the adapted test suite without the fix to see that (sending it as www encoded params was never intended in the api).

@hennevogel
Copy link
Member

So you do want to get rid of the (partial) json API?

@hennevogel hennevogel force-pushed the fix_issue_tracker_api branch from 630aa20 to 9e20369 Compare September 16, 2019 13:31
@hennevogel
Copy link
Member

How about this?

@hennevogel hennevogel force-pushed the fix_issue_tracker_api branch from 9e20369 to b00ce73 Compare September 16, 2019 13:48
Copy link
Contributor

@vpereira vpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be consistent, create and destroy should return the XML normally generated by the method render_ok.

eg. via

 # osc api -e /issue_trackers/$tracker

we need to backport in case 2.10 is also affected.

Also all other places in test suite where "put ...., params: $body_data"
is used needs to be checked if we broke the api there as well.
needs to become raw_put again...
@hennevogel hennevogel force-pushed the fix_issue_tracker_api branch from b00ce73 to 216a857 Compare February 25, 2020 20:21
@hennevogel
Copy link
Member

@vpereira please have another look

@hennevogel hennevogel force-pushed the fix_issue_tracker_api branch from 216a857 to 69951ce Compare February 25, 2020 23:11
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #8346 into master will increase coverage by 0.03%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8346      +/-   ##
==========================================
+ Coverage   90.95%   90.98%   +0.03%     
==========================================
  Files         507      507              
  Lines       20532    20518      -14     
==========================================
- Hits        18674    18669       -5     
+ Misses       1858     1849       -9

This didn't work and never was supposed to be exposed via JSON.
@hennevogel
Copy link
Member

@adrianschroeter this changes the API now, see the included chunk for api.txt. I think it makes sense, are you okay with that?

@adrianschroeter
Copy link
Member Author

@hennevogel seems you forgot to commit the chunk for api.txt?

If it is just about the drop of .json, I am fine with it (it seems to not usable anyway so far at least for writing).

@hennevogel hennevogel force-pushed the fix_issue_tracker_api branch from 69951ce to c7680aa Compare February 26, 2020 09:11
@hennevogel
Copy link
Member

Indeed I have. pushed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants