-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] fix editing of issue tracker entries #8346
[api] fix editing of issue tracker entries #8346
Conversation
Maybe you can explain what the problem actually is that you are fixing? |
that it isn't working basically and all changes get ignored when use as described in the api. Just run the adapted test suite without the fix to see that (sending it as www encoded params was never intended in the api). |
So you do want to get rid of the (partial) json API? |
630aa20
to
9e20369
Compare
How about this? |
9e20369
to
b00ce73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be consistent, create
and destroy
should return the XML normally generated by the method render_ok
.
eg. via # osc api -e /issue_trackers/$tracker we need to backport in case 2.10 is also affected. Also all other places in test suite where "put ...., params: $body_data" is used needs to be checked if we broke the api there as well. needs to become raw_put again...
b00ce73
to
216a857
Compare
@vpereira please have another look |
216a857
to
69951ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #8346 +/- ##
==========================================
+ Coverage 90.95% 90.98% +0.03%
==========================================
Files 507 507
Lines 20532 20518 -14
==========================================
- Hits 18674 18669 -5
+ Misses 1858 1849 -9 |
This didn't work and never was supposed to be exposed via JSON.
@adrianschroeter this changes the API now, see the included chunk for |
@hennevogel seems you forgot to commit the chunk for api.txt? If it is just about the drop of .json, I am fine with it (it seems to not usable anyway so far at least for writing). |
69951ce
to
c7680aa
Compare
Indeed I have. pushed now |
eg. via
# osc api -e /issue_trackers/$tracker
we need to backport in case 2.10 is also affected.
Also all other places in test suite where "put ...., params: $body_data"
is used needs to be checked if we broke the api there as well.
needs to become raw_put again...