Improve error message during staging request #8483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoj
added
Frontend
dmarcoux
suggested changes
Oct 1, 2019
There was a problem hiding this comment.
As I said before in #8450 (comment)
With the current changes, a user cannot know if the request doesn't exist. It might happen because he/she mistypes the request number.
Make it clear that a request was not found in a Staging for a project. Also give a proper message when the request doesn't exist at all. Fixes openSUSE#7355. Co-authored-by: David Kang <dkang@suse.com>
eduardoj
force-pushed
the
fix_7355_wrong_error_message
branch
from
45c60b0 to
2ed6122
Compare
A different error message was added, for covering the case that a request doesn't exist. Please re-review. |
dmarcoux
approved these changes
Oct 1, 2019
|
codecov hangs. coveralls is fine. merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that a request was not found in a Staging for a project.
Fixes #7355.
Co-authored-by: David Kang dkang@suse.com