Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[src/api] Upgrade sassc: 2.1.0 → 2.2.1 (minor)" #8489

Closed

Conversation

DavidKang
Copy link
Contributor

Reverts #8459

This update is causing an error in docker when we start from scratch. We have to wait for sass/sassc-ruby#146 to be fixed.

@vpereira
Copy link
Contributor

vpereira commented Oct 1, 2019

hm, sorry I'm not able to reproduce it.

what I did:

docker prune -s (you have to rebuild even the frontend-base)
rake docker:build

it worked for me

Copy link
Contributor

@vpereira vpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all related containers and images and try again.

For me after docker system prune -a worked

@DavidKang DavidKang closed this Oct 1, 2019
@DavidKang DavidKang deleted the revert-8459-depfu/update/srcapi/sassc-2.2.1 branch October 1, 2019 14:02
@saraycp
Copy link
Contributor

saraycp commented Oct 7, 2019

This is still causing problems when we set the containers from scratch. @DavidKang can we re-open this, please?

@saraycp
Copy link
Contributor

saraycp commented Oct 7, 2019

This is still causing problems when we set the containers from scratch. @DavidKang can we re-open this, please?

No worries, I've opened a new one: #8526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants