Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display obs quality category setting next to the project name #8493

Conversation

danidoni
Copy link
Contributor

@danidoni danidoni commented Oct 1, 2019

This PR adds the Quality category attribute next to the project name. This makes easier to spot the category of such projects.

Before you had to go and click each one of the projects, go to its Attributes tab and then look at the attributes you needed.

Here is a screenshot of how it looks:

Before
image

After
image

Fixes #8144

@dmarcoux dmarcoux added Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started labels Oct 1, 2019
Copy link
Member

@hennevogel hennevogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing specs, especially for Project

src/api/app/assets/stylesheets/webui/datatables.scss Outdated Show resolved Hide resolved
src/api/app/helpers/webui/projects/attributes_helper.rb Outdated Show resolved Hide resolved
@obs-bot
Copy link
Collaborator

obs-bot commented Oct 1, 2019

src/api/app/controllers/webui/project_controller.rb Outdated Show resolved Hide resolved
src/api/app/helpers/webui/projects/attributes_helper.rb Outdated Show resolved Hide resolved
src/api/app/views/webui/project/index.html.haml Outdated Show resolved Hide resolved
src/api/app/models/project/categorized.rb Outdated Show resolved Hide resolved
src/api/app/models/project.rb Show resolved Hide resolved
@dmarcoux dmarcoux dismissed their stale review October 2, 2019 13:57

My review was addressed.

@danidoni danidoni force-pushed the display-obs-quality-category-setting-next-to-the-project-name branch from 37723a0 to b7d431b Compare October 7, 2019 15:21
src/api/spec/models/project_spec.rb Outdated Show resolved Hide resolved
@danidoni danidoni force-pushed the display-obs-quality-category-setting-next-to-the-project-name branch from b7d431b to 1efe245 Compare October 8, 2019 06:55
@hennevogel hennevogel merged commit b4ba20c into openSUSE:master Oct 8, 2019
@danidoni danidoni deleted the display-obs-quality-category-setting-next-to-the-project-name branch November 12, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display OBS:QualityCategory setting next to the project
4 participants