Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deleting a staging project with staged requests #8511

Merged

Conversation

DavidKang
Copy link
Contributor

@DavidKang DavidKang commented Oct 4, 2019

Fix #7361

without staged requests

Screenshot_2019-10-07 Open Build Service

with staged requests

Screenshot_2019-10-07 Open Build Service(1)

Co-authored-by: Eduardo Navarro enavarro@suse.com

@DavidKang DavidKang added Frontend Things related to the OBS RoR app staging-workflow Things related to the staging workflow feature labels Oct 4, 2019
Copy link
Contributor

@vpereira vpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR is fine, however a test case would be great!

@DavidKang DavidKang force-pushed the staging-workflow/fix-real-7361 branch 2 times, most recently from d02e1ca to 41dbcdc Compare October 7, 2019 09:26
@DavidKang
Copy link
Contributor Author

@vpereira, could you review it again, please?

Copy link
Contributor

@vpereira vpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please fix the linter!

David Kang and others added 2 commits October 7, 2019 12:40
Fix openSUSE#7361

Co-authored-by: Eduardo Navarro <enavarro@suse.com>
Co-authored-by: Eduardo Navarro <enavarro@suse.com>
@DavidKang DavidKang force-pushed the staging-workflow/fix-real-7361 branch from 41dbcdc to f010e7f Compare October 7, 2019 10:40
@hennevogel
Copy link
Member

codecov hangs. coveralls is fine. merging!

@hennevogel hennevogel merged commit e21429d into openSUSE:master Oct 7, 2019
@DavidKang DavidKang deleted the staging-workflow/fix-real-7361 branch October 8, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app staging-workflow Things related to the staging workflow feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a staging project doesn't move requests back into backlog
4 participants