Always use public path to logfile in webui

[krauselukas]

There is no benefit in using different routes to the log file,
for authenticated and non authenticated users in the webui,
since both deliver the exact same result.

Fixes #9880

[dmarcoux]

We could get rid of the build#logfile action since it wouldn't be used anymore once this PR is merged.

Edit: Forget this comment, it's an API endpoint. 🙈

[codecov]

Codecov Report

Merging #9980 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9980   +/-   ##
=======================================
  Coverage   90.51%   90.51%           
=======================================
  Files         566      566           
  Lines       21236    21236           
=======================================
  Hits        19222    19222           
  Misses       2014     2014           

[adrianschroeter]

On Mittwoch, 5. August 2020, 14:42:21 CEST wrote Lukas Krause:

There is no benefit in using different routes to the log file, for authenticated and non authenticated users in the webui, since both deliver the exact same result.

/public is not always enabled. You most likely make it impossible to access logfiles on anonymous off instances.

…

Fixes #9880 <!--- If you haven't done so already, please read the CONTRIBUTING.md file to learn how we work and what we expect from all contributors. https://github.com/openSUSE/open-build-service/blob/master/CONTRIBUTING.md In order to make it as easy as possible for other developers to review your pull request we ask you to: - Explain what this PR is about in the description - Explain the steps the reviewer has to follow to verify your change - If the reviewer needs sample data to verify your change, please explain how to create that data - If you include visual changes in this PR, please add screenshots or GIFs - If you address performance in this PR, add benchmark data or explain how the reviewer can benchmark this This is a good PR description example: Hey Friends, this introduces labels for the different build result states on the project monitor page. This makes it easier to get a visual overview of what is going on in your project. To verify this feature - Enable the interconnect to build.opensuse.org - Create the project home:Admin - Add 'openSUSE Tumbleweed' as a repository to the project - Branch a couple of packages into the project: ``` for i in `osc -A http://0.0.0.0:3000 ls openSUSE.org:home:hennevogel`; do osc -A http://0.0.0.0:3000 copypac openSUSE.org:home:hennevogel $i home:Admin; done ``` - Visit the monitor page and see the new labels for the different states. Here is a screenshot of how it looks: ** Before **  ** After **  --> You can view, comment on, or merge this pull request online at: #9980 -- Commit Summary -- * Always use public path to logfile in webui -- File Changes -- M src/api/app/views/webui/package/_live_build_log_controls.html.haml (21) -- Patch Links -- https://github.com/openSUSE/open-build-service/pull/9980.patch https://github.com/openSUSE/open-build-service/pull/9980.diff

-- Adrian Schroeter email: adrian@suse.de SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany

[adrianschroeter]

also sourceaccess or access disabled projects will not work anymore

[krauselukas]

@adrianschroeter ok, thanks for pointing this out 👍