Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve conflict between WebMock and Webdrivers #2648

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Resolve conflict between WebMock and Webdrivers #2648

merged 1 commit into from
Mar 6, 2021

Conversation

AndrewKvalheim
Copy link
Member

@AndrewKvalheim AndrewKvalheim commented Mar 28, 2020 •
edited
Loading

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works(if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

Webdrivers attempts to automatically install/update ChromeDriver, but WebMock blocks it, causing tests to fail (#2557):

$ docker-compose run --rm osem bundle exec rake db:bootstrap
$ docker-compose run --rm osem bundle exec rspec --fail-fast --tag js
…
          WebMock::NetConnectNotAllowedError:
            Real HTTP connections are disabled. Unregistered request: GET https://chromedriver.storage.googleapis.com/LATEST_RELEASE_80.0.3987 …

Changes proposed in this pull request

Whitelist the update URLs, as in titusfortner/webdrivers#109.

@AndrewKvalheim AndrewKvalheim mentioned this pull request Apr 11, 2020
Open
2 tasks
AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request May 31, 2020
@AndrewKvalheim
Merge pull request openSUSE#2648
8fce57c
AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request May 31, 2020
@AndrewKvalheim
Merge pull request openSUSE#2648
1e12f75
@AndrewKvalheim @hennevogel
Whitelist Webdrivers update URLs in WebMock
fa129d2 
Resolves openSUSE#2557:

    $ docker-compose run --rm osem bundle exec rspec --tag js
    …
    WebMock::NetConnectNotAllowedError

See titusfortner/webdrivers#109 for details.
@hennevogel hennevogel force-pushed the webmock-webdrivers branch from e657d37 to fa129d2 Compare March 6, 2021 18:20
@hennevogel hennevogel merged commit 58d51c6 into openSUSE:master Mar 6, 2021
@AndrewKvalheim AndrewKvalheim deleted the webmock-webdrivers branch June 13, 2021 19:27
@AndrewKvalheim AndrewKvalheim mentioned this pull request Jan 20, 2022
Closed
@AndrewKvalheim
Copy link
Member Author

Update: titusfortner/webdrivers#254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hennevogel hennevogel hennevogel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewKvalheim @hennevogel