Allow leaving OSEM_SMTP_DOMAIN unset #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI currently failing at #2703 |
hennevogel
approved these changes
Mar 6, 2021
Allows leaving `smtp_settings[:domain]` unspecified. Explicitly setting it to `nil` (as when `OSEM_SMTP_DOMAIN` is unset) overrides the default value of `'localhost.localdomain'` and caused SMTP connections to fail with `EOFError`.
hennevogel
force-pushed
the
omit-nil-smtp-settings
branch
from
e530fbe to
266fdba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Short description of what this resolves
The SMTP setting
:domain(i.e. HELO domain) is often unnecessary and falls back to a reasonable default.Leaving
OSEM_SMTP_DOMAINunset, however, currently causes:domainto be explicitly set tonil, which in our case caused mail delivery to fail withEOFError.Changes proposed in this pull request
Omit
nilvalues from the Action Mailer configuration.