Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mimemagic #2745

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Update mimemagic #2745

merged 2 commits into from
Apr 13, 2021

Conversation

differentreality
Copy link
Contributor

@differentreality differentreality commented Apr 11, 2021

  • Update mimemagic due to licensing issues
  • gh actions failed to work with ruby v 2.5.8 (not sure if we want to update ruby version for actions or we need to look into this from another angle)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works(if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves/which issues does this fix?:

Changes proposed in this pull request:

@hennevogel
Copy link
Member

gh actions failed to work with ruby v 2.5.8

How did it fail?

@differentreality
Copy link
Contributor Author

https://github.com/openSUSE/osem/pull/2746/checks?check_run_id=2316875818

Your Ruby version is 2.5.9, but your Gemfile specified 2.5.8

@hennevogel hennevogel merged commit d647f64 into openSUSE:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants