Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update venue country name for Countries 4.2 #2962

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

AndrewKvalheim
Copy link
Member

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

Countries 4.2 has deprecated #name and OSEM currently emits a warning:

DEPRECATION WARNING: The Country#name method has been deprecated. Please use Country#iso_short_name instead or refer to the README file for more information on this change.

Changes proposed in this pull request

Use #iso_short_name instead.

Resolves:

    DEPRECATION WARNING: The Country#name method has been deprecated.
    Please use Country#iso_short_name instead or refer to the README
    file for more information on this change.

Details: https://github.com/countries/countries/blob/v4.2.2/README.markdown#upgrading-to-42-and-5x
@hennevogel hennevogel merged commit 5c7c75b into openSUSE:master Mar 8, 2022
@AndrewKvalheim AndrewKvalheim deleted the countries-4.2 branch March 9, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants