Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore test of splashpage revision history #2967

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

AndrewKvalheim
Copy link
Member

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

b688d35 makes three changes to the test of splashpage revision history:

The changed expectations cause a false negative.

Changes proposed in this pull request

Revert the changed expectations and re-enable the test.

This reverts the changes to `spec/features/versions_spec.rb` made in
commit b688d35, except for the change
that was proposed in issue openSUSE#2703.
@hennevogel hennevogel merged commit 83a6313 into openSUSE:master Mar 15, 2022
@AndrewKvalheim AndrewKvalheim deleted the splashpage-versions-test branch March 16, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants