-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GitHub tarballs #110
Comments
The format I have used for https://build.opensuse.org/package/show/home:jayvdb:pyexcel/python-pyexcel-io
|
Example decline for tests not being included from the GitHub repo : https://build.opensuse.org/request/show/670793 Another package I recently ran into where it would be nice to have the tests automatically added https://build.opensuse.org/request/show/666395 , though in that case the tests were not passing. |
An example where the maintainer has shown, in the past, to be reticent to including tests, citing that they are available on GitHub ryanmcgrath/twython#507 |
Nah, it is easier to just switch to github tags if the upstream is semi-dead or refusing to ship the tests rather than use syntax like this. We already have cca 100 packages in main repo doing that. For us it really matters not where from the first source is obtained from, esp. if upstream is stubborn. |
Also one of the things why we should just switch is space consideration, less we consume on the VCS the better, thus 2 almost exact copies of archive are way worse than 1. |
@scarabeusiv with "just switch" you mean we should use github tag tarballs instead of pypi tarballs? |
Yep in a case where nobody wants to tweak the package on pypi for our needs just use the github tag (of course you are out of luck if even those tags are missing). By no means this should be default behaviour, but if it allows us to execute the tests... |
ok. good. we are in sync then :) |
SO py2pack can look for tests in the pypi package, and if there are none then follow a GitHub link to find tests in the repo? And then use GitHub is that is the only place the tests were found? |
https://github.com/jayvdb/pypidb finds the GitHub repo for almost any PyPI package. Currently I am checking all packages in devel:languages:python* prefixed The packages I couldnt/didnt map to PyPI names are in https://github.com/jayvdb/pypidb/blob/ba7740e/tests/datasets.py#L287 . There is a mapping of openSUSE names to PyPI names directly above that, which may be incomplete. The list of those PyPI packages in openSUSE that do not yet find an SCM is at https://github.com/jayvdb/pypidb/blob/master/tests/test_osc.py as "expected_failures" . I suspect some of those will be missing mappings from openSUSE names to PyPI names, which the team here might be able to spot quickly. The tests do check packages in |
Actually, if you see packages which are too obsolete/broken/whatever even for d:l:p:misc don't hesitate to delete them/suggest their deletion, please. |
I don't see this ticket leading to any actionable item in my TODO list. Please, reopen with the appropriate argument, if you feel otherwise. |
Sometimes it is useful/necessary to fetch the source tarballs from the git/hg/etc repo, especially to get tests which are excluded from the PyPi package.
Also, it would be nice if py2pack could ensure this approach is done in a safe manner, using PyPi for the main content, and then splicing in extra content in the source repo's tarball.
The text was updated successfully, but these errors were encountered: