Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include tests in source tarballs #60

Closed
jayvdb opened this issue Feb 7, 2019 · 8 comments
Closed

Include tests in source tarballs #60

jayvdb opened this issue Feb 7, 2019 · 8 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Feb 7, 2019

No description provided.

@jayvdb
Copy link
Contributor Author

jayvdb commented Feb 7, 2019

Also for pyexcel , pyexcel-xls, pyexcel-xlsx being packaged at https://build.opensuse.org/project/show/home:jayvdb:pyexcel

Then the others ... ;-)

@chfw
Copy link
Member

chfw commented Feb 7, 2019

Thanks for your effort in packaging pyexcel. I will do so at your command.

@chfw
Copy link
Member

chfw commented Feb 7, 2019

Just did a googling. Emendonca did include into opensuse, though not the latest nor your standard.

Anyway thanks for both of you.

@jayvdb
Copy link
Contributor Author

jayvdb commented Feb 7, 2019

I based my packages on Emendonca's, so their contribution is included in the history.

@jayvdb
Copy link
Contributor Author

jayvdb commented Feb 8, 2019

fwiw, I have a fairly easy workaround described at openSUSE/py2pack#110 , so this isnt a high priority now.

@jayvdb
Copy link
Contributor Author

jayvdb commented Feb 8, 2019

For https://github.com/pyexcel/pyexcel , it also needs to include examples.

And they all should include docs , so doctest can be run

@chfw chfw mentioned this issue Feb 9, 2019
Merged
@chfw chfw closed this as completed in d8d076b Feb 9, 2019
@chfw
Copy link
Member

chfw commented Feb 10, 2019

Hold on. 0.5.12 did too much.

chfw added a commit that referenced this issue Feb 12, 2019
@chfw
🥚 🎡 0.5.13. fix #53, related to #61, #60 and pyexcel/pyexcel-xls#30
2b69509
This was referenced Feb 12, 2019
Merged
Closed
@jayvdb
Copy link
Contributor Author

jayvdb commented Feb 13, 2019

Just noting, when doing this for the other pyexcel packages, see #65

@jtojnar jtojnar mentioned this issue Aug 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @chfw