Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests missing from the archive #35

Closed
jtojnar opened this issue Aug 27, 2020 · 11 comments
Closed

Tests missing from the archive #35

jtojnar opened this issue Aug 27, 2020 · 11 comments

Comments

@jtojnar
Copy link

jtojnar commented Aug 27, 2020

Looks like the tests are still missing in https://files.pythonhosted.org/packages/source/p/pyexcel-xls/pyexcel-xls-0.5.8.tar.gz.

See also pyexcel/pyexcel-io#60

@chfw
Copy link
Member

chfw commented Aug 27, 2020

MANIFEST.in will include tests but the change was made 8 months ago. But v0.5.8 was released in 2018 and ever since, I have not updated the package.

Do you need tests for something?

@jtojnar
Copy link
Author

jtojnar commented Aug 27, 2020

Just like python-lml/lml#9, I am packaging pyexcel for a linux distro (NixOS/nixpkgs#96483) and would like to run the tests to increase our certainty things are okay.

@chfw
Copy link
Member

chfw commented Aug 28, 2020

sure and thanks for spreading the love. I will make one release with tests.

@chfw
Copy link
Member

chfw commented Aug 29, 2020

Tests folder seems to be there?

https://github.com/pyexcel/pyexcel-xls/archive/0.5.8.tar.gz

x pyexcel-xls-0.5.8/setup.cfg
x pyexcel-xls-0.5.8/setup.py
x pyexcel-xls-0.5.8/test.bat
x pyexcel-xls-0.5.8/test.sh
x pyexcel-xls-0.5.8/tests/
x pyexcel-xls-0.5.8/tests/_compact.py
x pyexcel-xls-0.5.8/tests/base.py
x pyexcel-xls-0.5.8/tests/fixtures/
x pyexcel-xls-0.5.8/tests/fixtures/complex-merged-cells-sheet.xls
x pyexcel-xls-0.5.8/tests/fixtures/complex_hidden_sheets.xls
x pyexcel-xls-0.5.8/tests/fixtures/date_field.xls
x pyexcel-xls-0.5.8/tests/fixtures/file_with_an_empty_sheet.xls
x pyexcel-xls-0.5.8/tests/fixtures/hidden.xls
x pyexcel-xls-0.5.8/tests/fixtures/hidden_sheets.xls
x pyexcel-xls-0.5.8/tests/fixtures/merged-cell-sheet.xls
x pyexcel-xls-0.5.8/tests/fixtures/merged-sheet-exploration.xls
x pyexcel-xls-0.5.8/tests/fixtures/pyexcel_issue_151.xlsx
x pyexcel-xls-0.5.8/tests/fixtures/test-date-format.xls
x pyexcel-xls-0.5.8/tests/requirements.txt
x pyexcel-xls-0.5.8/tests/requirements3.txt
x pyexcel-xls-0.5.8/tests/test_bug_fixes.py
x pyexcel-xls-0.5.8/tests/test_filter.py
x pyexcel-xls-0.5.8/tests/test_formatters.py
x pyexcel-xls-0.5.8/tests/test_hidden.py
x pyexcel-xls-0.5.8/tests/test_merged_cells.py
x pyexcel-xls-0.5.8/tests/test_multiple_sheets.py
x pyexcel-xls-0.5.8/tests/test_stringio.py
x pyexcel-xls-0.5.8/tests/test_writer.py

@chfw
Copy link
Member

chfw commented Aug 29, 2020

but the file you mentioned, indeed, does not have the tests. I will cook up v0.5.9 from master branch

@chfw chfw closed this as completed Aug 29, 2020
@chfw chfw reopened this Aug 29, 2020
@jtojnar
Copy link
Author

jtojnar commented Aug 29, 2020

https://github.com/pyexcel/pyexcel-xls/archive/0.5.8.tar.gz is just a snapshot of the Git repo, distros are typically getting python packages from PyPI https://pypi.org/project/pyexcel-xls/#files

@chfw
Copy link
Member

chfw commented Aug 29, 2020

Do you still need 0.5.9 with tests?

@jtojnar
Copy link
Author

jtojnar commented Aug 29, 2020

It would be very useful but we can also package it without tests until you are ready to release a new version.

@chfw
Copy link
Member

chfw commented Aug 29, 2020

The next release will be 0.6.0 if it is not urgent.

Pyexcel-io v0.6.0 is under development so soon all its plugins will get an upgrade to 0.6.0 line.

@chfw
Copy link
Member

chfw commented Aug 29, 2020

a maintenance version is produced here: https://pypi.org/project/pyexcel-xls/0.5.9/

@chfw chfw closed this as completed Aug 29, 2020
@jtojnar
Copy link
Author

jtojnar commented Aug 29, 2020

Thank you, updated: NixOS/nixpkgs@5cfd827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants