Add support for name, pkgs and diff_attr parameters to zypperpkg.upgrade()/yumpkg.upgrade() - backport 3004 #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f)
Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7)
pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae)
diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
SchoolGuy
approved these changes
Jun 15, 2022
meaksh
pushed a commit
that referenced
this pull request
Dec 28, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
meaksh
pushed a commit
that referenced
this pull request
Dec 28, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
meaksh
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
meaksh
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
meaksh
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
meaksh
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
diff_attrtoyumpkg.upgrade()and add it, together withnameandpkgs, tozypperpkg.upgrade().Backport of saltstack/salt#62033