Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reusable validator CI workflow #81

Merged
merged 13 commits into from
Jan 29, 2025
Prev Previous commit
Next Next commit
Fix
nickevansuk committed Jan 21, 2025
commit a356c35aef2a902379758eee9031d7dd221af676
2 changes: 1 addition & 1 deletion .github/workflows/test-and-deploy.yml
Original file line number Diff line number Diff line change
@@ -143,13 +143,13 @@ jobs:
run: npm run start &

- name: Lost Pixel
continue-on-error: true
uses: lost-pixel/lost-pixel@v3.16.0
env:
LOST_PIXEL_MODE: update

# Note this deletes the branch and PR if differences are resolved
- name: Create Pull Request
continue-on-error: true
id: cpr
uses: peter-evans/create-pull-request@v6
with:

Unchanged files with check annotations Beta

break;
}
} catch (e) {
console.error(e);

Check warning on line 109 in src/client/components/Rpde.jsx

GitHub Actions / test-site

Unexpected console statement

Check warning on line 109 in src/client/components/Rpde.jsx

GitHub Actions / create-pr-to-update-lost-pixel-baseline

Unexpected console statement
this.setState({
validating: false,
isError: true,
responseBody.validationModeHint = validationModeHint;
res.status(200).json(responseBody);
} catch (e) {
console.error(e);

Check warning on line 218 in src/server/server.js

GitHub Actions / test-site

Unexpected console statement

Check warning on line 218 in src/server/server.js

GitHub Actions / create-pr-to-update-lost-pixel-baseline

Unexpected console statement
res.status(400).json({
json: parsedJson,
response: [{
app.ws('/ws', (ws) => {
ws.on('message', (message) => {
console.log(message);

Check warning on line 234 in src/server/server.js

GitHub Actions / test-site

Unexpected console statement

Check warning on line 234 in src/server/server.js

GitHub Actions / create-pr-to-update-lost-pixel-baseline

Unexpected console statement
// Is this a URL?
if (!message.match(/^http/)) {
ws.send(JSON.stringify({
}));
} else {
// Do the validation
console.log(`${new Date()} trying validation for ${message}`);

Check warning on line 243 in src/server/server.js

GitHub Actions / test-site

Unexpected console statement

Check warning on line 243 in src/server/server.js

GitHub Actions / create-pr-to-update-lost-pixel-baseline

Unexpected console statement
const options = {
logCallback: (log) => {
if (log.verbosity === 1) {
options,
).then(
(res) => {
console.log(`${new Date()} validation completed`);

Check warning on line 276 in src/server/server.js

GitHub Actions / test-site

Unexpected console statement

Check warning on line 276 in src/server/server.js

GitHub Actions / create-pr-to-update-lost-pixel-baseline

Unexpected console statement
ws.send(JSON.stringify({
type: 'results',
url: message,
},
).catch(
(err) => {
console.error(`${new Date()} validation errored`);

Check warning on line 285 in src/server/server.js

GitHub Actions / test-site

Unexpected console statement

Check warning on line 285 in src/server/server.js

GitHub Actions / create-pr-to-update-lost-pixel-baseline

Unexpected console statement
console.error(err);

Check warning on line 286 in src/server/server.js

GitHub Actions / test-site

Unexpected console statement

Check warning on line 286 in src/server/server.js

GitHub Actions / create-pr-to-update-lost-pixel-baseline

Unexpected console statement
ws.send(JSON.stringify({
type: 'error',
data: 'The validator encountered an error and could not complete',