Per validation mode required and recommended rules #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is one present otherwise just use the default one attached to model spec at root level
… if there is one present otherwise just use the default one attached to model spec at root level
…here is one present otherwise just use the default one attached to model spec at root level
|
Hi @nickevansuk this PR provides updates to existing rules as discussed about openactive/data-models#41. Rule for shallNotInclude to follow (left it on a different computer, doh!). |
|
Related to openactive/data-models#45 |
ylt
approved these changes
Oct 24, 2019
thtg88
approved these changes
Oct 24, 2019
henryaddison
deleted the
per-validation-mode-required-and-recommended-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rules on requiredFields, recommendedFields and requiredOptions to use the definition specific to the current validationMode if there is one. Otherwise falls back on the default, top-level definition.
Part of openactive/data-models#41