feat: B/P detailed errors #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The remaining errors are actually to do with the validator: which doesn’t currently differentiate between responses with OrderItem errors, and responses without. I’ve updated the validator to do this (openactive/data-models#91) and just checking through the PR now. The main thing this does is add additional validation modes We should update this PR so that the test suite uses these too. Once done all tests should pass 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the tests to expect detailed errors for stage B (and P in approval flow).
There are still quite a few tests failing. I've tried to make sure the only tests that are failing, are failing because the reference implementation is broken (ie the tests should be failing).
Related issue: openactive/open-booking-api#218
(Branch renamed from #488 to pass CI)