-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add validThroughBeforeStartDate
#604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
civsiv
reviewed
Oct 2, 2023
...st-interface-criteria/src/criteria/TestOpportunityBookableOutsideValidFromBeforeStartDate.js
Outdated
Show resolved
Hide resolved
civsiv
approved these changes
Oct 2, 2023
lukehesluke
requested changes
Oct 3, 2023
...st-interface-criteria/src/criteria/TestOpportunityBookableOutsideValidFromBeforeStartDate.js
Outdated
Show resolved
Hide resolved
...st-interface-criteria/src/criteria/TestOpportunityBookableOutsideValidFromBeforeStartDate.js
Outdated
Show resolved
Hide resolved
nickevansuk
commented
Oct 3, 2023
packages/test-interface-criteria/built-types/types/Criteria.d.ts
Outdated
Show resolved
Hide resolved
lukehesluke
approved these changes
Oct 3, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic support for
validThroughBeforeStartDate
to ensure that test suite does not fail for systems that implement this (as per #605)