Check for invalid min/max values from the server #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xist before building queries based on them
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @iandees, noticed a case in openaddresses/openaddresses/pull/3867 with ArcGIS 10.22 where the server returns an invalid min/max. pyesridump then tries to build requests based on those values, but none of the IDs in the range exist. This PR adds a simple
returnIdsOnlyquery with a "WHERE {id} = {minval} OR {id} = {maxval}" to test whether the values returned by the server exist, and raises an error if not so OID enumeration will be tried. Now that OID enumeration is relatively fast, it shouldn't be as much of an issue to use it occasionally. Modified the test cases as well to add the new query where it's necessary.