Fixed _build_query_args method when extra_query_args are passed #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48 and closes #49.
The issue occurred whenever I passed
extra_query_args
to the EsriDumper that looked likewhere="ModifiedDate>'2018-04-29'"
. Theseextra_query_args
were later processed inside the_build_query_args
method and the method would incorrectly result in args:where=(None) AND ModifiedDate>'2018-04-29'
.So the PR just adds a check for the
requested_where
.