Short circuit if query yields no results #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks so much for this awesome library!
This PR adds a logic to short circuit further queries if the initial result count is 0. It also adds a test for this behavior.
I made this change because the min/max IDs of an empty result set are null (e.g.), which causes
_get_layer_min_max
to fail with the error reported here: datamade/census_area#12I thought it made more sense to stop if we know there are no results to return, rather than to handle the error in the min/max comparison.
I like that this approach is agnostic about whether no results is good or bad (as opposed to raising an error), but I'm happy for your feedback, if you'd prefer a different behavior!
Let me know what you think. 🙃