fix: ensure ref is initialized #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi thanks for this, I'll get some tests in place so we don't regress here again. |
weedon-openai
approved these changes
Oct 9, 2025
weedon-openai
added a commit
that referenced
this pull request
Oct 9, 2025
weedon-openai
added a commit
that referenced
this pull request
Oct 9, 2025
chore: Add changeset for #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35:
The
openai-chatkitref was never set before using it, which lead to the options/events never being applied. After this change, the issue in #35 seems to be resolved.Both lint and tests pass.