Merged
Conversation
owenlin0
reviewed
Jan 28, 2026
Collaborator
There was a problem hiding this comment.
I think we still need to map the core event to ThreadItem::ContextCompaction, see bespoke_event_handling.rs
unfortunately in app-server we still operate on EventMsgs instead of TurnItems from core. not sure if it's possible to use the as_legacy_event thing to emit both EventMsg::ContextCompactionStarted and EventMsg::ContextCompactionEnded somehow
| - `exitedReviewMode` — `{id, review}` emitted when the reviewer finishes; `review` is the full plain-text review (usually, overall notes plus bullet point findings). | ||
| - `compacted` - `{threadId, turnId}` when codex compacts the conversation history. This can happen automatically. | ||
| - `contextCompaction` — `{id}` emitted when codex compacts the conversation history. This can happen automatically. | ||
| - `compacted` - `{threadId, turnId}` when codex compacts the conversation history. This can happen automatically. **Deprecated:** Use `contextCompaction` instead. |
Collaborator
There was a problem hiding this comment.
Maybe we can just remove this one from the README
owenlin0
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External (non-OpenAI) Pull Request Requirements
Before opening this Pull Request, please read the dedicated "Contributing" markdown file or your PR may be closed:
https://github.com/openai/codex/blob/main/docs/contributing.md
If your PR conforms to our contribution guidelines, replace this text with a detailed and high quality description of your changes.
Include a link to a bug report or enhancement request.