TUI: Render request_user_input results in history and simplify interrupt handling #10064

charley-oai · 2026-01-28T05:05:07Z

Summary

This PR improves the TUI experience for request_user_input by rendering submitted question/answer sets directly in conversation history with clear, structured formatting.

It also intentionally simplifies interrupt behavior for now: on Esc / Ctrl+C, the questions overlay interrupts the turn without attempting to submit partial answers.

Scope

TUI-only changes.
No core/protocol/app-server behavior changes in this PR.
Resume reconstruction of interrupted question sets is out of scope for this PR.

What Changed

Added a new history cell: RequestUserInputResultCell in codex-rs/tui/src/history_cell.rs.
On normal request_user_input submission, TUI now inserts that history cell immediately after sending Op::UserInputAnswer.
Rendering includes a Questions header with answered/total count.
Rendering shows each question as a bullet item.
Rendering styles submitted answer lines in cyan.
Rendering styles notes (for option questions) as note: lines in cyan.
Rendering styles freeform text (for no-option questions) as answer: lines in cyan.
Rendering dims only the (unanswered) suffix.
Rendering can include an interrupted suffix and summary text when the cell is marked interrupted.
Rendering redacts secret questions as •••••• instead of showing raw values.
Added wrap_with_prefix(...) in history_cell.rs for wrapped prefixed lines.
Added split_request_user_input_answer(...) in history_cell.rs for decoding "user_note: ..." entries.

Interrupt Behavior (Intentional for this PR)

Esc / Ctrl+C in the questions overlay now performs Op::Interrupt and exits the overlay.
It does not submit partial/committed answers on interrupt.
Added TODO comments in request_user_input overlay interrupt paths indicating where interrupted partial result emission should be reintroduced once core support is finalized.
Queued request_user_input overlays are discarded on interrupt in the current behavior.

Tests Updated

Updated/added overlay tests in codex-rs/tui/src/bottom_pane/request_user_input/mod.rs to reflect interrupt-only behavior.
Added helper assertion for interrupt-only event expectation.
Existing submission-path tests now validate history insertion behavior and expected answer maps.

Behavior Notes

Completed question flows now produce a readable Questions block in transcript history.
Interrupted flows currently do not persist partial answers to model-visible tool output.

Follow-ups

Reintroduce partial-answer-on-interrupt semantics once core can persist/sequence interrupted request_user_input outputs safely.
Optionally add replay/resume rendering for interrupted question sets as a separate PR.

Codex author

codex fork 019bfb8d-2a65-7313-9be2-ea7100d19a61

charley-oai · 2026-01-28T05:12:02Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eae4941f89

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/state/turn.rs

charley-oai · 2026-01-28T05:36:25Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d755995341

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/codex.rs

charley-oai · 2026-01-28T19:52:05Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93737eb14a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/codex.rs

charley-oai · 2026-01-29T08:38:24Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e3aa042db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/state/turn.rs

charley-oai · 2026-01-30T03:47:28Z

@codex review this

chatgpt-codex-connector · 2026-01-30T04:02:21Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-01-30T04:08:08Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18fd1fb1a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/codex.rs

charley-oai · 2026-01-30T07:56:09Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f90a06fbc2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-01-30T08:30:41Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 586cf07b2f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-01-30T15:34:48Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c385209012

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/codex.rs

charley-oai · 2026-01-30T16:49:17Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ae9698b32b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-01-30T18:00:43Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce40172e60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-02-03T01:03:54Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1a5d62a99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-03T01:09:34Z

codex-rs/tui/src/history_cell.rs

+            if answer_missing && let Some(last) = question_lines.last_mut() {
+                last.spans.push(" (unanswered)".dim());


Preserve unanswered suffix in wrapping

The (unanswered) suffix is appended after wrap_with_prefix finishes wrapping the question text, so for long questions or narrow terminal widths the suffix can overflow the line and be truncated by the renderer. In that case the user loses the unanswered indicator even though the question is still unanswered. Consider including the suffix in the wrapped text (or placing it on its own wrapped line) so the marker is never pushed past the width limit.

Useful? React with 👍 / 👎.

charley-oai changed the base branch from main to ask-user-question-is-other-in-tui January 28, 2026 05:05

charley-oai force-pushed the partially-submit-user-answers branch from f1ce61c to eae4941 Compare January 28, 2026 05:11

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

codex-rs/core/src/state/turn.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

codex-rs/core/src/codex.rs Outdated Show resolved Hide resolved

charley-oai force-pushed the partially-submit-user-answers branch from d755995 to ce98d0e Compare January 28, 2026 07:06

Base automatically changed from ask-user-question-is-other-in-tui to main January 28, 2026 17:42

charley-oai force-pushed the partially-submit-user-answers branch from ce98d0e to 93737eb Compare January 28, 2026 19:44

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

codex-rs/core/src/codex.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 29, 2026

View reviewed changes

codex-rs/core/src/state/turn.rs Outdated Show resolved Hide resolved

charley-oai force-pushed the partially-submit-user-answers branch from a2d9589 to f4a934c Compare January 29, 2026 08:53

charley-oai force-pushed the partially-submit-user-answers branch from 23df216 to 18fd1fb Compare January 30, 2026 04:07

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

codex-rs/core/src/codex.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved