Skip to content

feat: sort metadata by date #10083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jif-oai merged 1 commit into from
Jan 28, 2026
+9 −0
Merged

feat: sort metadata by date #10083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions codex-rs/core/src/rollout/metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ use codex_state::DB_ERROR_METRIC;
use codex_state::ExtractionOutcome;
use codex_state::ThreadMetadataBuilder;
use codex_state::apply_rollout_item;
use std::cmp::Reverse;
use std::path::Path;
use std::path::PathBuf;
use tracing::warn;
Expand Down Expand Up @@ -144,6 +145,14 @@ pub(crate) async fn backfill_sessions(
}
}
}
rollout_paths.sort_by_key(|(path, _archived)| {
let parsed = path
.file_name()
.and_then(|name| name.to_str())
.and_then(parse_timestamp_uuid_from_filename)
Comment on lines +148 to +152
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep archived copies from being overwritten on backfill

This sort ignores the archived flag and sort_by_key is not stable, so if the same rollout file exists in both sessions and archived_sessions (e.g., an interrupted archive move or manual copy), the unarchived copy can be processed last and upsert_thread will overwrite the archived record, clearing archived_at. Previously the loop order guaranteed archived files were applied after sessions. Consider including archived in the sort key (or preserving the original root ordering) so archived copies always win when duplicates exist.

Useful? React with 👍 / 👎.

Copy link
Collaborator Author

@jif-oai jif-oai Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant

.unwrap_or((time::OffsetDateTime::UNIX_EPOCH, uuid::Uuid::nil()));
(Reverse(parsed.0), Reverse(parsed.1))
});
let mut stats = BackfillStats {
scanned: 0,
upserted: 0,
Expand Down
Loading